[improve][broker] Supplement schema ledger if schema ledger is lost#20415
Open
Denovo1998 wants to merge 10 commits intoapache:masterfrom
Open
[improve][broker] Supplement schema ledger if schema ledger is lost#20415Denovo1998 wants to merge 10 commits intoapache:masterfrom
Denovo1998 wants to merge 10 commits intoapache:masterfrom
Conversation
2 tasks
Contributor
Author
|
@poorbarcode @congbobo184 @codelipenghui |
|
The pr had no activity for 30 days, mark with Stale label. |
Contributor
Author
|
Waiting to discuss whether this plan is feasible. I will send an email to discuss it later. |
|
The pr had no activity for 30 days, mark with Stale label. |
15 tasks
Contributor
Author
|
In the alternative, the implementation is updated. Needs to be discussed. |
15 tasks
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java # pulsar-broker/src/test/java/org/apache/pulsar/broker/service/schema/SchemaServiceTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20414
Master Issue: ##20414
Motivation
#17221 describes an environment when multiple bookie copies are corrupted, or a Ledger has been deleted. The loss of schema ledger results in new producers and consumers not even being created and working properly.
So we need a solution that does not just skip the schema with the missing ledger, but actually supplements the broken schema ledger.
Modifications
Add a new method
tryCompleteTheLostSchema()inSchemaStorageandSchemaRegistrySchemaStorageFormat.SchemaEntrybuilt withschemaDataandschemaVersion.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Denovo1998#4